View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003868 | unreal | ircd | public | 2009-10-01 19:06 | 2015-08-08 16:38 |
| Reporter | ericoc | Assigned To | syzop | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 3.2.8 | ||||
| Summary | 0003868: Failed server link connection notices are impossible to hide. | ||||
| Description | I've setup a mesh link configuration in line with http://www.x-tab.org/unreal.html#meshlink . Since it's mesh, all of the servers have autoconnect; link blocks to one another. The problem is that if a single server in the network goes down, all of the other active servers send non-stop connection attempt notices (similar to the ones below) to all of the opers. 07:25 [NeoturbineNET] !eric.neoturbine.net *** Notice -- Connecting to eli.neoturbine.net[eli.neoturbine.net]. 07:25 [NeoturbineNET] !eric.neoturbine.net *** Notice -- No response from eli.neoturbine.net, closing link 07:26 [NeoturbineNET] !eric.neoturbine.net *** Global -- from beastlyfingers.intheskywithdiamonds.net: No response from eli.neoturbine.net, closing link Even turning of all snomasks (/mode eric -s) does not hide the notices. | ||||
| Steps To Reproduce | 1. Setup two or more servers linked together (three would be good to see just how many notices are sent) in the mesh topology described at http://www.x-tab.org/unreal.html#meshlink . 2. Oper up on any one of the servers. 3. Split any one of the servers; simply turning off Unreal is fine. 4. Watch the two working servers send continuous notices every few seconds (whatever's specified in connfreq; I'm guessing?) 5. Turn all snomasks off (/mode yournick -s) and the notices will still be sent to you. | ||||
| Additional Information | The only way I see to get rid of this is to not be oper'd up if you don't need to be or to JUPE the server with something like Anope, but I don't think that the real server can re-link to the network when it comes back online if there's a JUPE in place. | ||||
| Attached Files | irssi.png (85,231 bytes) unrealircd-3.2.9-CONNECT-snomask.patch (4,701 bytes) unrealircd-3.2.9-CONNECT-snomask-1.patch (6,085 bytes) | ||||
| 3rd party modules | |||||
|
|
I tested the patch and I stopped seeing my own server's failed link notices when I turned off the new C snomask with /mode eric +s -C I still see all of the failed link notices from other servers on the network though. I applied the patch to another server on the network, but I still saw that server's failed link notices as an oper on my own server. Thanks ohnobinki, I know you're still working on this... :) |
|
|
ericoc, for the servers which you applied the first patch to, you may apply the short upgrade patch at http://ohnopublishing.net/gitweb/unrealircd.ohno.git?a=commitdiff_plain;h=f0aecf547a40c826304aa993083f4a7ae78c68c0 . I'm going to repost another patch which includes documentation changes soon. |
|
|
Well... I tried with the short patch first and was having odd results, so I ended up just killing the installs (saving the configs) and going from scratch with the full patch you offered. Now, I'm only seeing my own server's link failed notices with the C snomask. If I turn snomask C off, I stop getting the link failed notices that my own server sends. I'm not seeing any failed link notices from other servers on the network whether snomask C is on or off. I'm also not getting the failed link notices from another server on the network that I applied the patch to either. |
|
|
> I'm not seeing any failed link notices from other servers on the network whether snomask C is on or off. I'm very positive that my patch should not affect that case when these link failed notices are originating at non-patched servers. If you're on a non-patched server, you should not be able to recieve the messages from the patched server because the server you're opered up on needs to recognize the C snomask. > I'm also not getting the failed link notices from another server on the network that I applied the patch to either. Did you get these before? All of the functions I converted except for the ``No response from %s, closing link'' message are only sent to opers locally connected to the server AFAIK. If this message fails to make it from one patched server to another, then I need someone to explain why this happens because I can't find such a situation in the source code. |
|
|
Aren't these errors just too important to evade? Not that I'm against putting them in a snomask per-se, but.. Anyway, not for 3.2.9... |
|
|
See previous comment |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-10-01 19:06 | ericoc | New Issue | |
| 2009-10-01 19:06 | ericoc | File Added: irssi.png | |
| 2009-10-31 21:22 | ohnobinki | File Added: unrealircd-3.2.9-CONNECT-snomask.patch | |
| 2009-11-01 02:51 | ericoc | Note Added: 0015944 | |
| 2009-11-01 20:23 | ohnobinki | Note Added: 0015945 | |
| 2009-11-01 20:36 | ohnobinki | File Added: unrealircd-3.2.9-CONNECT-snomask-1.patch | |
| 2009-11-02 01:55 | ericoc | Note Added: 0015946 | |
| 2009-11-03 02:44 | ohnobinki | Note Added: 0015947 | |
| 2010-07-14 17:25 | syzop | Note Added: 0016172 | |
| 2015-08-08 16:38 | syzop | Note Added: 0018614 | |
| 2015-08-08 16:38 | syzop | Status | new => closed |
| 2015-08-08 16:38 | syzop | Assigned To | => syzop |
| 2015-08-08 16:38 | syzop | Resolution | open => no change required |
