View Issue Details

IDProjectCategoryView StatusLast Update
0003587unrealircdpublic2015-08-08 16:43
ReporterBock Assigned Tosyzop  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product Version3.2.8 
Summary0003587: some unused variables
DescriptionIn m_map.c I found some unused variables:

char servername[128][128];
int server_usercount[128];
int numservers = 0;

and I think what function static void dump_map(aClient *cptr, aClient *server, char *mask, int prompt_length, int length) can be without "mask" cos I don't find it to do something in code.



In comments:
/*
** New /MAP format. -Potvin
** m_map (NEW)
**
** parv[0] = sender prefix
** parv[1] = server mask
**/
I think what MAYBE it's for future searching in /map by mask, but:

    if (parc < 2)
        parv[1] = "*";

and:
        dump_map(sptr, &me, "*", 0, longest);

maybe instead "*" might be parv[1] but it's not :P and mask not used in dump_map.
I finished. :)
3rd party modules

Activities

Bock

2010-02-13 22:39

reporter   ~0016025

up?
for syzop :]

Bock

2010-11-22 18:05

reporter   ~0016443

Up? Easy fix, common

Issue History

Date Modified Username Field Change
2008-01-19 15:58 Bock New Issue
2010-02-13 22:39 Bock Note Added: 0016025
2010-11-22 18:05 Bock Note Added: 0016443
2015-08-08 16:43 syzop Status new => closed
2015-08-08 16:43 syzop Assigned To => syzop
2015-08-08 16:43 syzop Resolution open => fixed