View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002885 | unreal | installing | public | 2006-04-18 08:14 | 2015-08-08 17:56 |
| Reporter | Xuefer | Assigned To | syzop | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | unable to duplicate | ||
| Product Version | 3.2.4 | ||||
| Summary | 0002885: failed to compile src/charsys.c due to system locale problem | ||||
| Description | src/charsys.c(510) : error C2001: newline in constant src/charsys.c(511) : error C2143: syntax error : missing ')' before '}' src/charsys.c(607) : error C2001: newline in constant src/charsys.c(608) : error C2143: syntax error : missing ')' before '}' src/charsys.c(640) : error C2001: newline in constant starting from line 510-3: if (latin1 || !strcmp(name, "german")) { /* a", A", o", O", u", U" and es-zett */ charsys_addallowed("淠鲋撷); <- line 510 here } if (latin1 || !strcmp(name, "swiss-german")) { /* a", A", o", O", u", U" */ charsys_addallowed("淠鲋"); } if (latin1 || !strcmp(name, "dutch")) | ||||
| Steps To Reproduce | nmake -f makefile.win32 and wait for the error. suggested fix: make all non ascii string into "\xNN\xNN...\xNN\xNN" i have no problem under linux, tho. | ||||
| Additional Information | system locale: cp936 vc 2005, Chinese Simplified | ||||
| 3rd party modules | |||||
|
|
That huh.. Visual Studio modifies the source when it reads it ?? :P Oh.. or is that just because of the mantis paste.. :) There are no &codes, and no newline problems in there.. Is it because it reads it as some kind of other codepage as different characters - well that would been no problem, but.. with some different encoding too I gues... Hm.. Xuefer, does it help if you add: #pragma setlocale("english") at the top of src/charsys.c ? (well if it works I'll put it in config.h ..) I don't know if this actually makes MSVC read the file in proper ANSI/ASCII encoding, or if it only adds some locale shit in the resulting executable (we need the former, not the latter). PS: Just a warning, MSVC2005 causes crashes, 0002875, but if you happen to find out why.. let us know of course ;p PPS: if the pragma fix does not work then I suppose we would need to convert indeed, however that sucks (even with a tool/script..) :Pp. |
|
|
IE problem. latin chars was think as gbk chars when copy/paste, and before submit, characters that not in the charset of this html page, is converted into &code; not relatived to the bug itself. #pragma setlocale("english") does not help. #if 0 did. :P 0002875 is why i install vc2005. i'll attach patch there. |
|
|
Still an issue? |
|
|
I think it is. I wasn't too enthusiastic in 32* really, partly because it costs readability, partly because I was scared of breakage. And for 33*, we might switch to charset files, rather than hardcoded in C (which has always been an interim solution), so then this issue will disappear :) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-04-18 08:14 | Xuefer | New Issue | |
| 2006-04-18 08:38 | syzop | Note Added: 0011572 | |
| 2006-04-18 08:39 | syzop | Note Edited: 0011572 | |
| 2006-04-18 09:21 | syzop | Note Edited: 0011572 | |
| 2006-04-18 21:01 | Xuefer | Note Added: 0011573 | |
| 2007-04-27 03:51 |
|
Note Added: 0013779 | |
| 2007-04-27 03:51 |
|
Status | new => feedback |
| 2007-05-08 13:53 | syzop | Note Added: 0014054 | |
| 2015-08-08 17:56 | syzop | Status | feedback => closed |
| 2015-08-08 17:56 | syzop | Assigned To | => syzop |
| 2015-08-08 17:56 | syzop | Resolution | open => unable to duplicate |
